echo/CMake
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CMP0045: Remove support for OLD behavior

Browse Source
This commit is contained in:
Brad King 2024-12-05 14:07:19 -05:00
parent 9094eaa778
commit 1e8a744f07
12 changed files with 14 additions and 65 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Help/policy/CMP0045.rst
View File

@ -1,6 +1,9 @@
CMP0045
-------
.. |REMOVED_IN_CMAKE_VERSION| replace:: 4.0
.. include:: REMOVED_PROLOGUE.txt
Error on non-existent target in get_target_property.
In CMake 2.8.12 and lower, the :command:`get_target_property` command accepted
@ -13,7 +16,5 @@ for this policy is to issue a ``FATAL_ERROR`` if the command is called with a
non-existent target.
.. |INTRODUCED_IN_CMAKE_VERSION| replace:: 3.0
.. |WARNS_OR_DOES_NOT_WARN| replace:: warns
.. include:: STANDARD_ADVICE.txt
.. include:: DEPRECATED.txt
.. |WARNED_OR_DID_NOT_WARN| replace:: warned
.. include:: REMOVED_EPILOGUE.txt

32
Source/cmGetTargetPropertyCommand.cxx
View File

@ -2,13 +2,11 @@
file Copyright.txt or https://cmake.org/licensing for details. */
#include "cmGetTargetPropertyCommand.h"
#include <sstream>
#include "cmExecutionStatus.h"
#include "cmGlobalGenerator.h"
#include "cmMakefile.h"
#include "cmMessageType.h"
#include "cmPolicies.h"
#include "cmStringAlgorithms.h"
#include "cmTarget.h"
#include "cmValue.h"
@ -50,29 +48,11 @@ bool cmGetTargetPropertyCommand(std::vector<std::string> const& args,
}
}
} else {
bool issueMessage = false;
std::ostringstream e;
MessageType messageType = MessageType::AUTHOR_WARNING;
switch (mf.GetPolicyStatus(cmPolicies::CMP0045)) {
case cmPolicies::WARN:
issueMessage = true;
e << cmPolicies::GetPolicyWarning(cmPolicies::CMP0045) << "\n";
CM_FALLTHROUGH;
case cmPolicies::OLD:
break;
case cmPolicies::NEW:
issueMessage = true;
messageType = MessageType::FATAL_ERROR;
break;
}
if (issueMessage) {
e << "get_target_property() called with non-existent target \""
<< targetName << "\".";
mf.IssueMessage(messageType, e.str());
if (messageType == MessageType::FATAL_ERROR) {
return false;
}
}
mf.IssueMessage(
MessageType::FATAL_ERROR,
cmStrCat("get_target_property() called with non-existent target \"",
targetName, "\"."));
return false;
}
if (prop_exists) {
mf.AddDefinition(var, prop);

2
Source/cmPolicies.h
View File

@ -138,7 +138,7 @@ class cmMakefile;
NEW) \
SELECT(POLICY, CMP0045, \
"Error on non-existent target in get_target_property.", 3, 0, 0, \
WARN) \
NEW) \
SELECT(POLICY, CMP0046, \
"Error on non-existent dependency in add_dependencies.", 3, 0, 0, \
WARN) \

2
Tests/RunCMake/CMP0045/CMP0045-NEW-stderr.txt
View File

@ -1,4 +1,4 @@
CMake Error at CMP0045-NEW.cmake:4 \(get_target_property\):
CMake Error at CMP0045-NEW.cmake:[0-9]+ \(get_target_property\):
get_target_property\(\) called with non-existent target "tgt".
Call Stack \(most recent call first\):
CMakeLists.txt:3 \(include\)

3
Tests/RunCMake/CMP0045/CMP0045-NEW.cmake
View File

@ -1,4 +1 @@
cmake_policy(SET CMP0045 NEW)
get_target_property(result tgt TYPE)

10
Tests/RunCMake/CMP0045/CMP0045-OLD-stderr.txt
View File

@ -1,10 +0,0 @@
^CMake Deprecation Warning at CMP0045-OLD.cmake:2 \(cmake_policy\):
The OLD behavior for policy CMP0045 will be removed from a future version
of CMake.
The cmake-policies\(7\) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances. Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
Call Stack \(most recent call first\):
CMakeLists.txt:3 \(include\)$

4
Tests/RunCMake/CMP0045/CMP0045-OLD.cmake
View File

@ -1,4 +0,0 @@
cmake_policy(SET CMP0045 OLD)
get_target_property(result tgt TYPE)

1
Tests/RunCMake/CMP0045/CMP0045-WARN-result.txt
View File

@ -1 +0,0 @@
0

9
Tests/RunCMake/CMP0045/CMP0045-WARN-stderr.txt
View File

@ -1,9 +0,0 @@
CMake Warning \(dev\) at CMP0045-WARN.cmake:2 \(get_target_property\):
Policy CMP0045 is not set: Error on non-existent target in
get_target_property. Run "cmake --help-policy CMP0045" for policy details.
Use the cmake_policy command to set the policy and suppress this warning.
get_target_property\(\) called with non-existent target "tgt".
Call Stack \(most recent call first\):
CMakeLists.txt:3 \(include\)
This warning is for project developers. Use -Wno-dev to suppress it.

2
Tests/RunCMake/CMP0045/CMP0045-WARN.cmake
View File

@ -1,2 +0,0 @@
get_target_property(result tgt TYPE)

2
Tests/RunCMake/CMP0045/CMakeLists.txt
View File

@ -1,3 +1,3 @@
cmake_minimum_required(VERSION 2.8.12)
cmake_minimum_required(VERSION 3.10)
project(${RunCMake_TEST} CXX)
include(${RunCMake_TEST}.cmake)

3
Tests/RunCMake/CMP0045/RunCMakeTest.cmake
View File

@ -1,6 +1,3 @@
include(RunCMake)
set(RunCMake_IGNORE_POLICY_VERSION_DEPRECATION ON)
run_cmake(CMP0045-OLD)
run_cmake(CMP0045-NEW)
run_cmake(CMP0045-WARN)