echo/CMake
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

execute_process: Warn on unknown ENCODING value

Browse Source
This commit is contained in:
Brad King 2024-09-17 09:20:58 -04:00
parent d6e03018cb
commit 20f059d025
4 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Source/cmExecuteProcessCommand.cxx
View File

@ -308,6 +308,11 @@ bool cmExecuteProcessCommand(std::vector<std::string> const& args,
if (cm::optional<cmProcessOutput::Encoding> maybeEncoding =
cmProcessOutput::FindEncoding(*arguments.Encoding)) {
encoding = *maybeEncoding;
} else {
status.GetMakefile().IssueMessage(
MessageType::AUTHOR_WARNING,
cmStrCat("ENCODING option given unknown value \"", *arguments.Encoding,
"\". Ignoring."));
}
}
cmProcessOutput processOutput(encoding);

5
Tests/RunCMake/execute_process/EncodingUnknown-stderr.txt Normal file
View File

@ -0,0 +1,5 @@
^CMake Warning \(dev\) at EncodingUnknown\.cmake:[0-9]+ \(execute_process\):
ENCODING option given unknown value "unknown"\. Ignoring\.
Call Stack \(most recent call first\):
CMakeLists\.txt:[0-9]+ \(include\)
This warning is for project developers\. Use -Wno-dev to suppress it\.$

1
Tests/RunCMake/execute_process/EncodingUnknown.cmake Normal file
View File

@ -0,0 +1 @@
execute_process(ENCODING unknown COMMAND ${CMAKE_COMMAND} -E true)

1
Tests/RunCMake/execute_process/RunCMakeTest.cmake
View File

@ -8,6 +8,7 @@ run_cmake_command(MergeOutputFile ${CMAKE_COMMAND} -P ${RunCMake_SOURCE_DIR}/Mer
run_cmake_command(MergeOutputVars ${CMAKE_COMMAND} -P ${RunCMake_SOURCE_DIR}/MergeOutputVars.cmake)
run_cmake(EncodingMissing)
run_cmake(EncodingUnknown)
if(TEST_ENCODING_EXE)
run_cmake_script(EncodingCMP0176-NEW -DTEST_ENCODING_EXE=${TEST_ENCODING_EXE})
run_cmake_script(EncodingCMP0176-OLD -DTEST_ENCODING_EXE=${TEST_ENCODING_EXE})