echo/CMake
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

The error message for VISIBILITY_PRESET now documents valid options.

Browse Source 
Rather than just state the value for VISIBILITY_PRESET was invalid,
we additionally list the accepted values.
This commit is contained in:
Robert Maynard 2019-05-31 13:18:11 -04:00 committed by Brad King
parent 5e2d22c177
commit 619416f8a3
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/cmLocalGenerator.cxx
View File

@ -1914,7 +1914,9 @@ static void AddVisibilityCompileOption(std::string& flags,
strcmp(prop, "protected") != 0 && strcmp(prop, "internal") != 0) {
std::ostringstream e;
e << "Target " << target->GetName() << " uses unsupported value \"" << prop
<< "\" for " << flagDefine << ".";
<< "\" for " << flagDefine << "."
<< " The supported values are: default, hidden, protected, and "
"internal.";
cmSystemTools::Error(e.str());
return;
}

2
Tests/RunCMake/VisibilityPreset/PropertyTypo-stderr.txt
View File

@ -1 +1 @@
CMake Error: Target visibility_preset uses unsupported value \"hiden\" for CXX_VISIBILITY_PRESET
CMake Error: Target visibility_preset uses unsupported value \"hiden\" for CXX_VISIBILITY_PRESET. The supported values are: default, hidden, protected, and internal.