echo/CMake
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cmake: Simplify implementation of -E capabilities

Browse Source 
The `cmake -E capabilities` command-line tool is implemented only in a
full-featured (non-bootstrap) CMake, and server mode is now always
available in this case.
This commit is contained in:
Brad King 2019-06-07 09:33:11 -04:00
parent 6b815e58ba
commit 6696855f72
4 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/cmServerProtocol.cxx
View File

@ -630,7 +630,7 @@ cmServerResponse cmServerProtocol1::ProcessGlobalSettings(
Json::Value obj = Json::objectValue;
// Capabilities information:
obj[kCAPABILITIES_KEY] = cm->ReportCapabilitiesJson(true);
obj[kCAPABILITIES_KEY] = cm->ReportCapabilitiesJson();
obj[kDEBUG_OUTPUT_KEY] = cm->GetDebugOutput();
obj[kTRACE_KEY] = cm->GetTrace();

8
Source/cmake.cxx
View File

@ -248,7 +248,7 @@ Json::Value cmake::ReportVersionJson() const
return version;
}
Json::Value cmake::ReportCapabilitiesJson(bool haveServerMode) const
Json::Value cmake::ReportCapabilitiesJson() const
{
Json::Value obj = Json::objectValue;
@ -284,18 +284,18 @@ Json::Value cmake::ReportCapabilitiesJson(bool haveServerMode) const
generators.append(i.second);
}
obj["generators"] = generators;
obj["serverMode"] = haveServerMode;
obj["serverMode"] = true;
return obj;
}
#endif
std::string cmake::ReportCapabilities(bool haveServerMode) const
std::string cmake::ReportCapabilities() const
{
std::string result;
#if defined(CMAKE_BUILD_WITH_CMAKE)
Json::FastWriter writer;
result = writer.write(this->ReportCapabilitiesJson(haveServerMode));
result = writer.write(this->ReportCapabilitiesJson());
#else
result = "Not supported";
#endif

4
Source/cmake.h
View File

@ -136,9 +136,9 @@ public:
#if defined(CMAKE_BUILD_WITH_CMAKE)
Json::Value ReportVersionJson() const;
Json::Value ReportCapabilitiesJson(bool haveServerMode) const;
Json::Value ReportCapabilitiesJson() const;
#endif
std::string ReportCapabilities(bool haveServerMode) const;
std::string ReportCapabilities() const;
//@{
/**

6
Source/cmcmd.cxx
View File

@ -734,11 +734,7 @@ int cmcmd::ExecuteCMakeCommand(std::vector<std::string> const& args)
return 1;
}
cmake cm(cmake::RoleInternal, cmState::Unknown);
#if defined(CMAKE_BUILD_WITH_CMAKE)
std::cout << cm.ReportCapabilities(true);
#else
std::cout << cm.ReportCapabilities(false);
#endif
std::cout << cm.ReportCapabilities();
return 0;
}