echo/CMake
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FindArmadillo: Fix wrapper linking with MSVC

Browse Source 
Transitive linking does not work with MSVC, so we must link against both
Armadillo and its dependencies directly if `ARMA_USE_WRAPPER` is enabled.
This commit is contained in:
Ryan Curtin 2025-02-05 10:33:11 -05:00 committed by Brad King
parent bf47158d50
commit 6745af99c8
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Modules/FindArmadillo.cmake
View File

@ -99,8 +99,13 @@ if(_ARMA_USE_WRAPPER)
mark_as_advanced(ARMADILLO_LIBRARY)
set(_ARMA_REQUIRED_VARS ARMADILLO_LIBRARY)
else()
# Link directly to individual components.
set(ARMADILLO_LIBRARY "")
endif()
# Transitive linking with the wrapper does not work with MSVC,
# so we must *also* link against Armadillo's dependencies.
if(NOT _ARMA_USE_WRAPPER OR MSVC)
# Link directly to individual components.
foreach(pkg
LAPACK
BLAS