echo/CMake
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FPHSA: Consistent quoting in reported messages

Browse Source 
Command names are not enclosed into quotes/backticks and have `()`
at the end. Named arguments (keywords) have no quotes as well.
This commit is contained in:
Alex Turbov 2024-11-26 19:53:30 +04:00
parent 440d4446f5
commit a67df19d82
No known key found for this signature in database
GPG Key ID: 8BEDB7D11F95D5E3
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Modules/FindPackageHandleStandardArgs.cmake
View File

@ -297,8 +297,8 @@ function(FIND_PACKAGE_CHECK_VERSION version result)
if(NOT FPCV_NO_AUTHOR_WARNING_VERSION_RANGE if(NOT FPCV_NO_AUTHOR_WARNING_VERSION_RANGE
AND ${package}_FIND_VERSION_RANGE AND NOT FPCV_HANDLE_VERSION_RANGE) AND ${package}_FIND_VERSION_RANGE AND NOT FPCV_HANDLE_VERSION_RANGE)
message(AUTHOR_WARNING message(AUTHOR_WARNING
"`find_package()` specify a version range but the option " "find_package() specify a version range but the option "
"HANDLE_VERSION_RANGE` is not passed to `find_package_check_version()`. " "HANDLE_VERSION_RANGE` is not passed to find_package_check_version(). "
"Only the lower endpoint of the range will be used.") "Only the lower endpoint of the range will be used.")
endif() endif()
@ -389,7 +389,7 @@ function(FIND_PACKAGE_HANDLE_STANDARD_ARGS _NAME _FIRST_ARG)
list(FIND ARGN "NAME_MISMATCHED" name_mismatched_idx) list(FIND ARGN "NAME_MISMATCHED" name_mismatched_idx)
if(NOT name_mismatched_idx EQUAL "-1") if(NOT name_mismatched_idx EQUAL "-1")
message(FATAL_ERROR message(FATAL_ERROR
"The `NAME_MISMATCHED` argument may only be specified by the argument or " "The NAME_MISMATCHED argument may only be specified by the argument or "
"the variable, not both.") "the variable, not both.")
endif() endif()
@ -434,16 +434,16 @@ function(FIND_PACKAGE_HANDLE_STANDARD_ARGS _NAME _FIRST_ARG)
AND NOT FPHSA_NAME_MISMATCHED AND NOT FPHSA_NAME_MISMATCHED
AND NOT _NAME STREQUAL CMAKE_FIND_PACKAGE_NAME) AND NOT _NAME STREQUAL CMAKE_FIND_PACKAGE_NAME)
message(AUTHOR_WARNING message(AUTHOR_WARNING
"The package name passed to `find_package_handle_standard_args` " "The package name passed to find_package_handle_standard_args() "
"(${_NAME}) does not match the name of the calling package " "(${_NAME}) does not match the name of the calling package "
"(${CMAKE_FIND_PACKAGE_NAME}). This can lead to problems in calling " "(${CMAKE_FIND_PACKAGE_NAME}). This can lead to problems in calling "
"code that expects `find_package` result variables (e.g., `_FOUND`) " "code that expects find_package() result variables (e.g., `_FOUND`) "
"to follow a certain pattern.") "to follow a certain pattern.")
endif() endif()
if(${_NAME}_FIND_VERSION_RANGE AND NOT FPHSA_HANDLE_VERSION_RANGE) if(${_NAME}_FIND_VERSION_RANGE AND NOT FPHSA_HANDLE_VERSION_RANGE)
message(AUTHOR_WARNING message(AUTHOR_WARNING
"`find_package()` specify a version range but the module ${_NAME} does " "find_package() specify a version range but the module ${_NAME} does "
"not support this capability. Only the lower endpoint of the range " "not support this capability. Only the lower endpoint of the range "
"will be used.") "will be used.")
endif() endif()

8
Tests/RunCMake/FPHSA/NameMismatch-stderr.txt
View File

@ -1,8 +1,8 @@
CMake Warning \(dev\) at .*/Modules/FindPackageHandleStandardArgs.cmake:[0-9]+ \(message\): CMake Warning \(dev\) at .*/Modules/FindPackageHandleStandardArgs.cmake:[0-9]+ \(message\):
The package name passed to `find_package_handle_standard_args` The package name passed to find_package_handle_standard_args\(\)
\(NAMEMISMATCH\) does not match the name of the calling package \(NAMEMISMATCH\) does not match the name of the calling package
\(NameMismatch\). This can lead to problems in calling code that expects \(NameMismatch\). This can lead to problems in calling code that expects
`find_package` result variables \(e.g., `_FOUND`\) to follow a certain find_package\(\) result variables \(e.g., `_FOUND`\) to follow a certain
pattern. pattern.
Call Stack \(most recent call first\): Call Stack \(most recent call first\):
FindNameMismatch.cmake:[0-9]+ \(find_package_handle_standard_args\) FindNameMismatch.cmake:[0-9]+ \(find_package_handle_standard_args\)
@ -11,10 +11,10 @@ Call Stack \(most recent call first\):
This warning is for project developers. Use -Wno-dev to suppress it. This warning is for project developers. Use -Wno-dev to suppress it.
CMake Warning \(dev\) at .*/Modules/FindPackageHandleStandardArgs.cmake:[0-9]+ \(message\): CMake Warning \(dev\) at .*/Modules/FindPackageHandleStandardArgs.cmake:[0-9]+ \(message\):
The package name passed to `find_package_handle_standard_args` The package name passed to find_package_handle_standard_args\(\)
\(NAMEMISMATCH\) does not match the name of the calling package \(NAMEMISMATCH\) does not match the name of the calling package
\(NameMismatchOld\). This can lead to problems in calling code that expects \(NameMismatchOld\). This can lead to problems in calling code that expects
`find_package` result variables \(e.g., `_FOUND`\) to follow a certain find_package\(\) result variables \(e.g., `_FOUND`\) to follow a certain
pattern. pattern.
Call Stack \(most recent call first\): Call Stack \(most recent call first\):
FindNameMismatchOld.cmake:[0-9]+ \(find_package_handle_standard_args\) FindNameMismatchOld.cmake:[0-9]+ \(find_package_handle_standard_args\)

2
Tests/RunCMake/FPHSA/range_ignored-stderr.txt
View File

@ -1,4 +1,4 @@
CMake Warning \(dev\) at .+FindPackageHandleStandardArgs.cmake:[0-9]+ \(message\): CMake Warning \(dev\) at .+FindPackageHandleStandardArgs.cmake:[0-9]+ \(message\):
`find_package\(\)` specify a version range but the module Pseudo does not find_package\(\) specify a version range but the module Pseudo does not
support this capability. Only the lower endpoint of the range will be support this capability. Only the lower endpoint of the range will be
used. used.