echo/CMake
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TestDriver: Fix 'misc-use-anonymous-namespace' warning from clang-tidy 16

Browse Source 
C++ best practices recommend using anonymous namespace instead of a global
static qualifier.
This commit is contained in:
Sylvain Joubert 2023-04-25 11:29:28 +02:00
parent 26087d558f
commit ca2a84c3d7
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Templates/TestDriver.cxx.in
View File

@ -20,11 +20,19 @@
# else
# define CM_NULL NULL
# endif
# define CM_NAMESPACE_BEGIN namespace {
# define CM_NAMESPACE_END }
# define CM_LOCAL
#else
# define CM_CAST(TYPE, EXPR) (TYPE)(EXPR)
# define CM_NULL NULL
# define CM_NAMESPACE_BEGIN
# define CM_NAMESPACE_END
# define CM_LOCAL static
#endif
CM_NAMESPACE_BEGIN
/* Create map. */
typedef int (*MainFuncPointer)(int, char* []); /* NOLINT */
@ -34,17 +42,17 @@ typedef struct /* NOLINT */
MainFuncPointer func;
} functionMapEntry;
static functionMapEntry cmakeGeneratedFunctionMapEntries[] = {
CM_LOCAL const functionMapEntry cmakeGeneratedFunctionMapEntries[] = {
@CMAKE_FUNCTION_TABLE_ENTRIES@
{ CM_NULL, CM_NULL } /* NOLINT */
};
static const int NumTests = CM_CAST(int,
CM_LOCAL const int NumTests = CM_CAST(int,
sizeof(cmakeGeneratedFunctionMapEntries) / sizeof(functionMapEntry)) - 1;
/* Allocate and create a lowercased copy of string
(note that it has to be free'd manually) */
static char* lowercase(const char* string)
CM_LOCAL char* lowercase(const char* string)
{
char *new_string;
char *p;
@ -63,7 +71,7 @@ static char* lowercase(const char* string)
return new_string;
}
static int isTestSkipped(const char *name, int n_skipped_tests, char *skipped_tests[]) {
CM_LOCAL int isTestSkipped(const char *name, int n_skipped_tests, char *skipped_tests[]) {
int i;
for (i = 0; i < n_skipped_tests; i++) {
if (strcmp(name, skipped_tests[i]) == 0) {
@ -74,6 +82,8 @@ static int isTestSkipped(const char *name, int n_skipped_tests, char *skipped_te
return 0;
}
CM_NAMESPACE_END
int main(int ac, char* av[])
{
int i;