VS: Fix WinRT component references
WinRT components need to be referenced in a similar way that managed code libraries are referenced. Validate that the library reference is a WinRT component and reference it through the project. Add test coverage for `VS_WINRT_COMPONENT`. While at it, fix the IOT reference failing on Win10 SDK 17763 which doesn't include it anymore. Fixes: #18846
This commit is contained in:
parent
6c21722adb
commit
cff026dbc0
@ -3884,8 +3884,8 @@ void cmVisualStudio10TargetGenerator::WriteProjectReferences(Elem& e0)
|
||||
this->WriteDotNetReferenceCustomTags(e2, name);
|
||||
|
||||
// If the dependency target is not managed (compiled with /clr or
|
||||
// C# target) we cannot reference it and have to set
|
||||
// 'ReferenceOutputAssembly' to false.
|
||||
// C# target) and not a WinRT component we cannot reference it and
|
||||
// have to set 'ReferenceOutputAssembly' to false.
|
||||
auto referenceNotManaged =
|
||||
dt->GetManagedType("") < cmGeneratorTarget::ManagedType::Mixed;
|
||||
// Workaround to check for manually set /clr flags.
|
||||
@ -3902,6 +3902,12 @@ void cmVisualStudio10TargetGenerator::WriteProjectReferences(Elem& e0)
|
||||
if (referenceNotManaged && dt->GetType() == cmStateEnums::STATIC_LIBRARY) {
|
||||
referenceNotManaged = !dt->IsCSharpOnly();
|
||||
}
|
||||
|
||||
// Referencing WinRT components is okay.
|
||||
if (referenceNotManaged) {
|
||||
referenceNotManaged = !dt->GetPropertyAsBool("VS_WINRT_COMPONENT");
|
||||
}
|
||||
|
||||
if (referenceNotManaged) {
|
||||
e2.Element("ReferenceOutputAssembly", "false");
|
||||
e2.Element("CopyToOutputDirectory", "Never");
|
||||
|
@ -8,6 +8,8 @@ elseif(MSVC_VERSION GREATER 1600)
|
||||
set(COMPILER_VERSION "11")
|
||||
endif()
|
||||
|
||||
add_subdirectory(WinRT)
|
||||
|
||||
set (APP_MANIFEST_NAME Package.appxmanifest)
|
||||
if("${CMAKE_SYSTEM_NAME}" STREQUAL "WindowsPhone")
|
||||
set(PLATFORM WP)
|
||||
@ -149,5 +151,4 @@ if("${SHORT_VERSION}" STREQUAL "10.0")
|
||||
set_property(TARGET ${EXE_NAME} PROPERTY VS_SDK_REFERENCES "Microsoft.UniversalCRT.Debug, Version=${CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION}")
|
||||
endif()
|
||||
|
||||
|
||||
target_link_libraries(${EXE_NAME} d3d11)
|
||||
target_link_libraries(${EXE_NAME} d3d11 JusticeLeagueWinRT)
|
||||
|
@ -6,11 +6,15 @@ using namespace DirectX;
|
||||
using namespace Microsoft::WRL;
|
||||
using namespace Windows::Foundation;
|
||||
using namespace Windows::UI::Core;
|
||||
using namespace JusticeLeagueWinRT;
|
||||
|
||||
CubeRenderer::CubeRenderer()
|
||||
: m_loadingComplete(false)
|
||||
, m_indexCount(0)
|
||||
{
|
||||
// Create a new WinRT object to validate that we can link properly
|
||||
Batman ^ hero = ref new Batman();
|
||||
hero->savePeople();
|
||||
}
|
||||
|
||||
void CubeRenderer::CreateDeviceResources()
|
||||
|
14
Tests/VSWinStorePhone/WinRT/Batman.cpp
Normal file
14
Tests/VSWinStorePhone/WinRT/Batman.cpp
Normal file
@ -0,0 +1,14 @@
|
||||
#include "Batman.h"
|
||||
|
||||
using namespace JusticeLeagueWinRT;
|
||||
using namespace Platform;
|
||||
|
||||
Batman::Batman()
|
||||
{
|
||||
}
|
||||
|
||||
void Batman::savePeople()
|
||||
{
|
||||
int i = 0;
|
||||
i++;
|
||||
}
|
12
Tests/VSWinStorePhone/WinRT/Batman.h
Normal file
12
Tests/VSWinStorePhone/WinRT/Batman.h
Normal file
@ -0,0 +1,12 @@
|
||||
#pragma once
|
||||
|
||||
namespace JusticeLeagueWinRT {
|
||||
public
|
||||
ref class Batman sealed
|
||||
{
|
||||
public:
|
||||
Batman();
|
||||
|
||||
void savePeople();
|
||||
};
|
||||
}
|
13
Tests/VSWinStorePhone/WinRT/CMakeLists.txt
Normal file
13
Tests/VSWinStorePhone/WinRT/CMakeLists.txt
Normal file
@ -0,0 +1,13 @@
|
||||
project(JusticeLeagueWinRT CXX)
|
||||
|
||||
# create project
|
||||
add_library(JusticeLeagueWinRT SHARED
|
||||
"${CMAKE_CURRENT_SOURCE_DIR}/Batman.cpp"
|
||||
"${CMAKE_CURRENT_SOURCE_DIR}/Batman.h"
|
||||
)
|
||||
|
||||
set_target_properties(JusticeLeagueWinRT PROPERTIES
|
||||
VS_WINRT_COMPONENT TRUE
|
||||
VS_GLOBAL_ROOTNAMESPACE "JusticeLeagueWinRT"
|
||||
OUTPUT_NAME "JusticeLeagueWinRT"
|
||||
)
|
Loading…
Reference in New Issue
Block a user