31f73eb12d
The KWSys `SystemTools::SplitProgramFromArgs` implementation goes into an infinite loop when the value is just " " (a space). Since the "program path with unquoted spaces plus command-line arguments" operation it is trying to provide is poorly defined (string parsing should not depend on filesystem content), just stop using it. Instead consider the main two use cases the old approach tried to handle: * The value is the name or absolute path of a program with no quoting or escaping, but also no command-line arguments. In this case we can use the value as given with no parsing, and assume no arguments. * The value is a command-line string containing the program name/path plus arguments. In this case we now assume that the command line is properly quoted or escaped. Fixes: #17262
10 lines
429 B
ReStructuredText
10 lines
429 B
ReStructuredText
get_filename_component-fix-program-split
|
|
----------------------------------------
|
|
|
|
* The :command:`get_filename_component` ``PROGRAM`` mode semantics
|
|
have been revised to not tolerate unquoted spaces in the path
|
|
to the program while also accepting arguments. While technically
|
|
incompatible with the old behavior, it is expected that behavior
|
|
under typical use cases with properly-quoted command-lines has
|
|
not changed.
|